Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip flaky 'Page.goto extraHttpHeaders should be pushed to provisional page' #1203

Merged
merged 1 commit into from
Mar 4, 2020
Merged

test: skip flaky 'Page.goto extraHttpHeaders should be pushed to provisional page' #1203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/navigation.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,9 @@ module.exports.describe = function({testRunner, expect, playwright, MAC, WIN, FF
const error = await failed;
expect(error.message).toBeTruthy();
});
it('extraHttpHeaders should be pushed to provisional page', async({page, server}) => {
it.skip(true)('extraHttpHeaders should be pushed to provisional page', async({page, server}) => {
dgozman marked this conversation as resolved.
Show resolved Hide resolved
// This test is flaky, because we cannot await page.setExtraHTTPHeaders.
// We need a way to test our implementation by more than just public api.
await page.goto(server.EMPTY_PAGE);
const pagePath = '/one-style.html';
server.setRoute(pagePath, async (req, res) => {
Expand Down