browser(firefox): move workers to use SimpleChannel #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review URL: aslushnikov/juggler@4753d01 This patch: - Moves Workers to FrameTree - Introduces WorkerData in PageAgent that proxies runtime agent in worker to browser process - Introduces WorkerHandler in PageHandler that handles communicates with runtime agent in worker and handles Juggler protocol As part of this patch, SimpleChannel no longer manages lifetime of any of its handlers.
dgozman
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review URL: aslushnikov/juggler@4753d01
This patch:
in worker to browser process
with runtime agent in worker and handles Juggler protocol
As part of this patch, SimpleChannel no longer manages lifetime of
any of its handlers.