fix: allow toMatchSnapshot to use text comparator for text data #12934

aslushnikov · 2022-03-21T21:54:31Z

This was regressed awhile ago.

In v1.17 we shipped the following code:

playwright/packages/playwright-test/src/matchers/golden.ts

Lines 122 to 131 in 30e15ad

    
           const expected = fs.readFileSync(snapshotFile); 
        
           const extension = path.extname(snapshotFile).substring(1); 
        
           const mimeType = extensionToMimeType[extension] || 'application/octet-string'; 
        
           const comparator = GoldenComparators[mimeType]; 
        
           if (!comparator) { 
        
             return { 
        
               pass: false, 
        
               message: 'Failed to find comparator with type ' + mimeType + ': ' + snapshotFile, 
        
             }; 
        
           }

toMatchSnapshot should fallback to text comparator in case of
unknown extension and string data.

Fixes #12862

`toMatchSnapshot` should fallback to text comparator in case of unknown extension and string data. Fixes microsoft#12862

…rator for text data This was regressed awhile ago. In v1.17 we shipped the following code: https://github.com/microsoft/playwright/blob/30e15ad36f011c7adf5bad86beadd50ca93b01b8/packages/playwright-test/src/matchers/golden.ts#L122-L131 `toMatchSnapshot` should fallback to text comparator in case of unknown extension and string data. Fixes microsoft#12862

… text data (#12938) This was regressed awhile ago. In v1.17 we shipped the following code: https://github.com/microsoft/playwright/blob/30e15ad36f011c7adf5bad86beadd50ca93b01b8/packages/playwright-test/src/matchers/golden.ts#L122-L131 `toMatchSnapshot` should fallback to text comparator in case of unknown extension and string data. Fixes #12862

aslushnikov force-pushed the default-to-text-comparison-comparator branch from 3509708 to 079dda4 Compare March 21, 2022 21:55

aslushnikov changed the title ~~default to text comparison comparator~~ fix: allow toMatchSnapshot to use text comparator for text data Mar 21, 2022

dgozman approved these changes Mar 21, 2022

View reviewed changes

fix: allow toMatchSnapshot to use text comparator for text data

456b5b4

`toMatchSnapshot` should fallback to text comparator in case of unknown extension and string data. Fixes microsoft#12862

aslushnikov force-pushed the default-to-text-comparison-comparator branch from 92a6bef to 456b5b4 Compare March 21, 2022 22:28

aslushnikov merged commit 7f51336 into microsoft:main Mar 21, 2022

aslushnikov deleted the default-to-text-comparison-comparator branch March 21, 2022 23:42

pkerschbaum mentioned this pull request Mar 22, 2022

[Feature] Allow to use toMatchSnapshot for file formats other than txt (e.g. csv) #12862

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: allow toMatchSnapshot to use text comparator for text data #12934

fix: allow toMatchSnapshot to use text comparator for text data #12934

aslushnikov commented Mar 21, 2022 •

edited

Loading

	const expected = fs.readFileSync(snapshotFile);
	const extension = path.extname(snapshotFile).substring(1);
	const mimeType = extensionToMimeType[extension] \|\| 'application/octet-string';
	const comparator = GoldenComparators[mimeType];
	if (!comparator) {
	return {
	pass: false,
	message: 'Failed to find comparator with type ' + mimeType + ': ' + snapshotFile,
	};
	}

fix: allow toMatchSnapshot to use text comparator for text data #12934

fix: allow toMatchSnapshot to use text comparator for text data #12934

Conversation

aslushnikov commented Mar 21, 2022 • edited Loading

aslushnikov commented Mar 21, 2022 •

edited

Loading