api(chromium): add ChromiumBrowserContext.serviceWorkers() #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
Mar 18, 2020
| @@ -52,6 +52,7 @@ export class CRBrowser extends platform.EventEmitter implements Browser { | |||
| const promises = [ | |||
| session.send('Target.setDiscoverTargets', { discover: true }), | |||
| session.send('Target.setAutoAttach', { autoAttach: true, waitForDebuggerOnStart: true, flatten: true }), | |||
| session.send('Target.setDiscoverTargets', { discover: false }), | |||
There was a problem hiding this comment.
Is this temporary before you land your chromium patch?
There was a problem hiding this comment.
No, it's permanent, we don't need targetCreated/Destroyed notifications anymore, just attachedToTarget/detachedFromTarget.
| @@ -3861,6 +3862,9 @@ Emitted when new service worker is created in the context. | |||
| - `page` <[Page]> Page to create new session for. | |||
| - returns: <[Promise]<[CDPSession]>> Promise that resolves to the newly created session. | |||
|
|
|||
| #### chromiumBrowserContext.serviceWorkers() | |||
| - returns: <[Array]<[Worker]>> All existing service workers in the context. | |||
There was a problem hiding this comment.
Do we have origin on Worker? Determining who owns a service worker via its script url is unfortunate.
There was a problem hiding this comment.
We don't have it at the moment. We could expose similar Page.serviceWorkers(), or add ServiceWorker class that would allow to get a list of its clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: #1101