fix(test runner): screenshot immediately after failure #15159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Jun 27, 2022
Previously, screenshot was taken after hooks and fixtures teardown. However, hooks can easily modify the state of the page, and screenshot would not reflect the moment of failure. Instead, we take screenshots immediately after the test function finishes with an error.
dgozman
force-pushed
the
screenshot-immediately-on-failure
branch
from
bd88e5f to
b674048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, screenshot was taken after hooks and fixtures teardown. However, hooks can easily modify the state of the page, and screenshot would not reflect the moment of failure.
Now screenshots are taken immediately after the test function finishes with an error.
Fixes #14854.