feat(android): add Android.{launchServer,connect} #18263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
feature/android-add-launchserver
branch
from
c12d630
to
e620389
Compare
pavelfeldman
approved these changes
Oct 24, 2022
| async launchServer(options: LaunchAndroidServerOptions = {}): Promise<BrowserServer> { | ||
| const playwright = createPlaywright('javascript'); | ||
| // 1. Pre-connect to the device | ||
| let devices = await playwright.android.devices({ |
There was a problem hiding this comment.
I'd avoid a long-living connection here and would create a device upon the connection. I.e. instead of preLaunchedAndroidDevice: device pass preLaunchedAndroidDevice: deviceFactory.
There was a problem hiding this comment.
Good idea but this makes it harder when a device gets disconnected during launchServer and connect(). With the current impl the ws server will shut down when the adb connection drops.
| const data = await androidDevice.shell('cat /data/local/tmp/hello-world'); | ||
| expect(data).toEqual(Buffer.from('hello world')); | ||
| } finally { | ||
| await androidDevice.shell('rm /data/local/tmp/hello-world'); |
There was a problem hiding this comment.
This won't work for the timed out test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.