fix(electron): consistently emit ready event after app is loaded #18972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
ready_electron
branch
from
3b42f5b
to
5f01ae6
Compare
dgozman
approved these changes
Nov 21, 2022
andersk
reviewed
Dec 15, 2022
|
|
||
| (globalThis as any).__playwright_run = async () => { | ||
| // Wait for app to be ready to avoid browser initialization races. | ||
| await app.whenReady(); |
There was a problem hiding this comment.
This has caused a regression for apps using Electron APIs that need to be called before the ready event fires, such as protocol.registerSchemesAsPrivileged and app.disableHardwareAcceleration.
We need to give the user a chance to run synchronous code before the ready event fires for real—the Electron API is not fooled by our attempt to fake it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18928