Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove toIntersectViewport for the next release #20232

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 19, 2023

Mostly reverts #19901.

@dgozman dgozman merged commit d950f5b into microsoft:main Jan 19, 2023
@arieluchka-bse
Copy link

hi, why was this feature reverted?
is there an alternative to assert that an element shows fully in viewport?

@mxschmitt
Copy link
Member

Its called nowadays toBeInViewport()

@arieluchka-bse
Copy link

arieluchka-bse commented Jul 2, 2024

Its called nowadays toBeInViewport()

wasnt toIntersectViewport meant to validate chunks of the element? that the whole element is in the viewport and not only half of it?

i saw that the toBeInViewport() has "ratio" attribute, but it doesn't seem to work for me, so i wonder if im just using the wrong method, or is it just not compatible with our ui (angular, i think).

we have an element that on different viewports, half of it will collapse.
i am trying to write a test to validate the whole element is visible on different viewports.

image
image
vs
image
image

@arieluchka-bse
Copy link

was wondering if there is a functionality to allow validating the whole/parts of the element (toBeInViewport(ration=(int)) is not working for me :(
(using python)

@mxschmitt
Copy link
Member

Please file a new issue, thats a better point to triage bug reports. Thank you.

@arieluchka-bse
Copy link

should i open in playwrights repo or pythons playwright repo?
thank you for the help :)

@mxschmitt
Copy link
Member

mxschmitt commented Jul 2, 2024

https://github.com/microsoft/playwright/

Ideally with a repro/actual/expected outcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants