chore: extract pool builder, simplify project suite cloning #20235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
post_filter
branch
2 times, most recently
from
75c7fcf to
846127a
Compare
dgozman
approved these changes
Jan 19, 2023
|
|
||
| // Assign test properties with project-specific values. | ||
| result.forEachTest((test, suite) => { | ||
| suite._fileId = fileId; |
There was a problem hiding this comment.
If we have an empty suite, we'll never set its _fileId. I wonder whether that's a problem.
| import type { FullProjectInternal } from './types'; | ||
|
|
||
| export function filterTests(suite: Suite, filter: (test: TestCase) => boolean): boolean { | ||
| for (const child of suite.suites) { |
There was a problem hiding this comment.
suite.suites = suite.suites.filter(child => filterTests(child, filter));
pavelfeldman
force-pushed
the
post_filter
branch
from
846127a to
4a57169
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.