Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: bump Node.js versions 16->18 #22607

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/infra.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- run: npm i -g npm@8
- run: npm ci
- run: npm run build
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish_canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
registry-url: 'https://registry.npmjs.org'
- run: npm i -g npm@8
- run: npm ci
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- run: npm i -g npm@8
- name: Deploy Canary
run: bash utils/build/deploy-trace-viewer.sh --canary
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_release_docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
registry-url: 'https://registry.npmjs.org'
- uses: azure/docker-login@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_release_driver.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
registry-url: 'https://registry.npmjs.org'
- run: npm i -g npm@8
- run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_release_npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
registry-url: 'https://registry.npmjs.org'
- run: npm i -g npm@8
- run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_release_traceviewer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- run: npm i -g npm@8
- name: Deploy Stable
run: bash utils/build/deploy-trace-viewer.sh --stable
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/roll_browser_into_playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- run: npm i -g npm@8
- run: npm ci
- run: npm run build
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/tests_components.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
# Component tests require Node.js 16+ (they require ESM via TS)
node-version: 16
node-version: 18
- run: npm i -g npm@8
- run: npm ci
- run: npm run build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests_electron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- run: npm i -g npm@8
- run: npm ci
env:
Expand Down
17 changes: 8 additions & 9 deletions .github/workflows/tests_primary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ jobs:
matrix:
browser: [chromium, firefox, webkit]
os: [ubuntu-22.04]
node-version: [14]
node-version: [18]
include:
- os: ubuntu-22.04
node-version: 16
browser: chromium
- os: ubuntu-22.04
node-version: 18
node-version: 20
browser: chromium
runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -76,7 +76,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- run: npm i -g npm@8
- run: npm ci
env:
Expand All @@ -102,12 +102,12 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node-version: [16]
node-version: [18]
include:
- os: ubuntu-latest
node-version: 14
node-version: 16
- os: ubuntu-latest
node-version: 18
node-version: 20
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -135,8 +135,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
# Component tests require Node.js 16+ (they require ESM via TS)
node-version: 16
node-version: 18
- run: npm i -g npm@8
- run: npm ci
env:
Expand All @@ -158,7 +157,7 @@ jobs:
- macos-latest
- windows-latest
node_version:
- "^14.1.0" # pre 14.1, zip extraction was broken (https://github.com/microsoft/playwright/issues/1988)
- 18
timeout-minutes: 30
steps:
- uses: actions/checkout@v3
Expand Down
Loading