-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test runner): failed + skipped = flaky #26385
Conversation
Test results for "tests 1"7 failed 8 flaky 25044 passed, 583 skipped ❌ [playwright-test] › test-serial.spec.ts:98:5 › test.describe.serial should work with retry
❌ [playwright-test] › test-serial.spec.ts:98:5 › test.describe.serial should work with retry
❌ [playwright-test] › expect-poll.spec.ts:222:5 › should show intermediate result for poll that spills over test time
❌ [playwright-test] › test-serial.spec.ts:98:5 › test.describe.serial should work with retry
❌ [playwright-test] › test-serial.spec.ts:98:5 › test.describe.serial should work with retry
❌ [playwright-test] › reporter-html.spec.ts:1452:7 › merged › labels › filter should update stats
❌ [playwright-test] › test-serial.spec.ts:98:5 › test.describe.serial should work with retry
Merge workflow run. |
89f7d33
to
52ca875
Compare
Test results for "tests 1"13 flaky 25046 passed, 583 skipped Merge workflow run. |
There are plenty of edge cases in this area: - interrupted test run; - did not run because of serial mode failure; - failed before `test.skip()` call (e.g. in `beforeEach`) in one of the retries; - and more... Related issues: #28322, #28321, #27455, #17652. Prior changes: #27762, #26385, #28360, probably more. There is still some duplication between `outcome()` and similar logic in `base.ts`, which might be deduped in a follow-up. Fixes #28322.
Fixes #17652.