browser(firefox): support relative paths for firefox videos #27099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Sep 15, 2023
| @@ -236,7 +237,7 @@ export class FFBrowserContext extends BrowserContext { | |||
| // validateBrowserContextOptions ensures correct video size. | |||
| options: { | |||
| ...this._options.recordVideo!.size!, | |||
| dir: this._options.recordVideo!.dir, | |||
| dir: path.resolve(process.cwd(), this._options.recordVideo!.dir), | |||
There was a problem hiding this comment.
Should we fix it on the client instead? Sending a relative path over protocol sounds strange.
This comment has been minimized.
This comment has been minimized.
Firefox protocol requires absolute paths for video recording. Fixes microsoft#27086
aslushnikov
force-pushed
the
fix-ff-video-path
branch
from
62a1335
to
0256270
Compare
dgozman
approved these changes
Sep 15, 2023
Test results for "tests 1"6 flaky25623 passed, 605 skipped Merge workflow run. |
vogler
added a commit
to vogler/free-games-claimer
that referenced
this pull request
Sep 18, 2023
Recording videos with relative path as in docs was broken for Firefox. Issue: microsoft/playwright#27086 Can be reverted after PR is available in release: microsoft/playwright#27099
Germandrummer92
pushed a commit
to OctoMind-dev/playwright
that referenced
this pull request
Oct 27, 2023
…t#27099) Firefox protocol requires absolute paths for video recording. Fixes microsoft#27086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox protocol requires absolute paths for video recording.
Fixes #27086