fix(trace): EPERM on windows #27693
Merged
fix(trace): EPERM on windows #27693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
fix-win-eperm
branch
from
0ec6822 to
07e1416
Compare
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
fix-win-eperm
branch
from
07e1416 to
bcb119b
Compare
This comment has been minimized.
This comment has been minimized.
mxschmitt
reviewed
Oct 19, 2023
mxschmitt
approved these changes
Oct 19, 2023
When merging trace files, we sometimes left open read streams from the zip, which prevents it from being removed.
dgozman
force-pushed
the
fix-win-eperm
branch
from
bcb119b to
35dce80
Compare
dgozman
changed the title
Test results for "tests 1"6 flaky25907 passed, 603 skipped Merge workflow run. |
pavelfeldman
approved these changes
Oct 19, 2023
Germandrummer92
pushed a commit
to OctoMind-dev/playwright
that referenced
this pull request
Oct 27, 2023
When merging trace files, we sometimes left open read streams from the zip, which prevents it from being removed. Fixes microsoft#27286.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging trace files, we sometimes left open read streams from the zip, which prevents it from being removed.
Fixes #27286.