fix(keyboard): event order for Escape key #27711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Oct 19, 2023
mxschmitt
force-pushed
the
bugfix/event-order-for-Escape-key
branch
from
9028c2b to
9e187f7
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"2 failed 4 flaky25902 passed, 603 skipped Merge workflow run. |
Germandrummer92
pushed a commit
to OctoMind-dev/playwright
that referenced
this pull request
Oct 27, 2023
This test was failing in Chromium before this change. Caused by https://github.com/microsoft/playwright/blob/40d5e3a3c9957b8d7c22dfc69c4df0789974abc3/packages/playwright-core/src/server/chromium/crInput.ts#L54-L55 which messes up the order of the protocol calls. Fixes microsoft#27709.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing in Chromium before this change.
Caused by
playwright/packages/playwright-core/src/server/chromium/crInput.ts
Lines 54 to 55 in 40d5e3a
which messes up the order of the protocol calls.
Fixes #27709.