chore: make tests strict (1) #27731
Merged
chore: make tests strict (1) #27731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
test_strict
branch
from
3e5f23e to
a21f9da
Compare
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Oct 20, 2023
| @@ -562,9 +562,9 @@ it('should have popup requests', async ({ contextFactory, server }, testInfo) => | |||
| await popup.waitForLoadState(); | |||
| const log = await getLog(); | |||
|
|
|||
| expect(log.pages.length).toBe(2); | |||
| expect(log.pages!.length).toBe(2); | |||
There was a problem hiding this comment.
Should we just make pages non-nullable?
| @@ -33,19 +33,19 @@ test.describe('cli codegen', () => { | |||
| recorder.trustedClick(), | |||
| ]); | |||
|
|
|||
| expect.soft(sources.get('JavaScript').text).toContain(` | |||
| expect.soft(sources.get('JavaScript')!.text).toContain(` | |||
| @@ -172,8 +172,8 @@ it.describe('pause', () => { | |||
| const button = await page.waitForSelector('button'); | |||
| const box1 = await button.boundingBox(); | |||
|
|
|||
| const x1 = box1.x + box1.width / 2; | |||
| const y1 = box1.y + box1.height / 2; | |||
| const x1 = box1!.x + box1!.width / 2; | |||
There was a problem hiding this comment.
This is also painful for our users.
| expect(await root2.$eval(`css=#target`, e => e.textContent)).toBe('Hello from root2'); | ||
| expect(await root2.$(`css:light=#target`)).toBe(null); | ||
| const root2Shadow = await root2.evaluateHandle(r => r.shadowRoot); | ||
| const root2Shadow = (await root2.evaluateHandle(r => r.shadowRoot) as ElementHandle<ShadowRoot>)!; |
There was a problem hiding this comment.
Perhaps the following will also work?
Suggested change
| const root2Shadow = (await root2.evaluateHandle(r => r.shadowRoot) as ElementHandle<ShadowRoot>)!; | |
| const root2Shadow = await root2.evaluateHandle(r => r.shadowRoot!); |
| @@ -236,7 +237,7 @@ it('should work with *', async ({ page }) => { | |||
| expect(await page.$$eval('div *', els => els.length)).toBe(2); | |||
| expect(await page.$$eval('* > *', els => els.length)).toBe(6); | |||
|
|
|||
| const body = await page.$('body'); | |||
| const body = (await page.$('body')) as ElementHandle<HTMLBodyElement>; | |||
There was a problem hiding this comment.
Suggested change
| const body = (await page.$('body')) as ElementHandle<HTMLBodyElement>; | |
| const body = (await page.$('body'))!; |
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
test_strict
branch
from
a21f9da to
f40ff01
Compare
pavelfeldman
force-pushed
the
test_strict
branch
from
f40ff01 to
805993e
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"1 failed 10 flaky25935 passed, 603 skipped Merge workflow run. |
Germandrummer92
pushed a commit
to OctoMind-dev/playwright
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.