fix(inspector): highlight xpath/css locators without engine prefix #27742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
fix-inspect-xpath
branch
2 times, most recently
from
3f41d98 to
8d9b9f2
Compare
mxschmitt
force-pushed
the
fix-inspect-xpath
branch
from
8d9b9f2 to
3eed058
Compare
mxschmitt
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mxschmitt
commented
Oct 23, 2023
Signed-off-by: Max Schmitt <max@schmitt.mx>
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Oct 23, 2023
| if (typeof selector === 'string') | ||
| return selector; | ||
| return selector.parts.map((p, i) => { | ||
| const prefix = p.name === 'css' ? '' : p.name + '='; | ||
| let hideEngine = false; | ||
| if (!forceEngineName) { |
There was a problem hiding this comment.
While reading this, I realized that we cannot hide engine for the "capture" part.
Suggested change
| if (!forceEngineName) { | |
| if (!forceEngineName && i !== selector.capture) { |
| if (typeof selector === 'string') | ||
| return selector; | ||
| return selector.parts.map((p, i) => { | ||
| const prefix = p.name === 'css' ? '' : p.name + '='; | ||
| let hideEngine = false; |
There was a problem hiding this comment.
nit: for readability, I'd recommend includeEngine instead.
Test results for "tests 1"7 flaky25934 passed, 603 skipped Merge workflow run. |
Germandrummer92
pushed a commit
to OctoMind-dev/playwright
that referenced
this pull request
Oct 27, 2023
…icrosoft#27742) Motivation: As of today when a user inspects a Locator which is a xpath, it won't work if the user has not prefixed it with `xpath=` because we internally compare the given with the generated locator. Works: `locator('xpath=//div[contains(@Class, "foo")]')` Does not work: `locator('//div[contains(@Class, "foo")]')` Relates microsoft#27707 (comment) Fixes microsoft/playwright-dotnet#2718 (comment) --------- Signed-off-by: Max Schmitt <max@schmitt.mx>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: As of today when a user inspects a Locator which is a xpath, it won't work if the user has not prefixed it with
xpath=because we internally compare the given with the generated locator.Works:
locator('xpath=//div[contains(@class, "foo")]')Does not work:
locator('//div[contains(@class, "foo")]')Relates #27707 (comment)
Fixes microsoft/playwright-dotnet#2718 (comment)