Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(html): show top-level errors #27763

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Oct 24, 2023

Drive-by:

  • extract TestErrorView;
  • replace data-test-id with data-testid and getByTestId().

Screenshot 2023-10-23 at 5 20 16 PM

@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [installation tests] › playwright-cdn.spec.ts:40:7 › playwright cdn failover should work (https://playwright-akamai.azureedge.net)

6 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:55:5 › should run component tests after editing test
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › page/page-wait-for-navigation.spec.ts:85:3 › should work with clicking on links which do not commit navigation

25961 passed, 603 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit c8134bc into microsoft:main Oct 24, 2023
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
Drive-by:
- extract `TestErrorView`;
- replace `data-test-id` with `data-testid` and `getByTestId()`.

---

<img width="1001" alt="top-level errors in html report"
src="https://github.com/microsoft/playwright/assets/9881434/2d6c0c52-8df1-46a9-b3fd-06ddc6f16796">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants