fix: allow uploading large files on Android #27835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for "tests 1"1 failed 5 flaky25329 passed, 600 skipped Merge workflow run. |
yury-s
reviewed
Oct 27, 2023
| browser._interceptSetInputFilePaths = async (page, files) => { | ||
| const newLocalFiles = []; | ||
| for (const file of files) { | ||
| const localFileName = `/data/local/tmp/pw/${path.basename(file)}`; |
There was a problem hiding this comment.
this may clash with other file names
| @@ -343,6 +345,35 @@ export class AndroidDevice extends SdkObject { | |||
| validateBrowserContextOptions(options, browserOptions); | |||
|
|
|||
| const browser = await CRBrowser.connect(this.attribution.playwright, androidBrowser, browserOptions); | |||
| { | |||
| const androidArtifacts = new Set<string>(); | |||
| browser._interceptSetInputFilePaths = async (page, files) => { | |||
There was a problem hiding this comment.
This is quite a hack. I'd rather get createTempFile to create files on the android device, wdyt?
| @@ -333,6 +333,8 @@ export class CRPage implements PageDelegate { | |||
| } | |||
|
|
|||
| async setInputFilePaths(progress: Progress, handle: dom.ElementHandle<HTMLInputElement>, files: string[]): Promise<void> { | |||
| if (this._browserContext._browser._interceptSetInputFilePaths) | |||
There was a problem hiding this comment.
I'd rather revert the change that fixed lastModified, this becomes too hairy. Maybe we can move convertInputFiles logic to the server and let it properly handle the android case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27792