feat(playwright): add big sur beta support #2793
Conversation
Adding mac10.16 to be supported. This is the macOS Big Sur beta version. Begins to fix: microsoft#2789
|
|
| @@ -84,6 +86,7 @@ function getDownloadUrl(browserName: BrowserName, platform: BrowserPlatform): st | |||
| ['mac10.13', undefined], | |||
| ['mac10.14', '%s/builds/webkit/%s/minibrowser-mac-10.14.zip'], | |||
| ['mac10.15', '%s/builds/webkit/%s/minibrowser-mac-10.15.zip'], | |||
| ['mac10.16', '%s/builds/webkit/%s/minibrowser-mac-10.15.zip'], | |||
There was a problem hiding this comment.
I believe this requires a dedicated build similar to 10.14. We shouldn't provide a link for now unless it's working.
There was a problem hiding this comment.
tested on my big sur beta dev machine :)
There was a problem hiding this comment.
it could change when the actual big sur release is out.
| @@ -73,6 +74,7 @@ function getDownloadUrl(browserName: BrowserName, platform: BrowserPlatform): st | |||
| ['mac10.13', '%s/builds/firefox/%s/firefox-mac.zip'], | |||
| ['mac10.14', '%s/builds/firefox/%s/firefox-mac.zip'], | |||
| ['mac10.15', '%s/builds/firefox/%s/firefox-mac.zip'], | |||
| ['mac10.16', '%s/builds/firefox/%s/firefox-mac.zip'], | |||
There was a problem hiding this comment.
I don't have a Big Sur machine at hand. Does our current binary just work on 10.16?
There was a problem hiding this comment.
it does. just upgraded my dev machine to big sur yesterday. :)
which is why i opened this pr.
utils/check_availability.js
Outdated
| @@ -20,7 +20,7 @@ const browserFetcher = require('../lib/install/browserFetcher.js'); | |||
| const https = require('https'); | |||
| const SUPPORTER_PLATFORMS = ['linux', 'mac', 'win32', 'win64']; | |||
|
|
|||
| const fetcherOptions = SUPPORTER_PLATFORMS.map(platform => platform === 'mac' ? 'mac10.15' : platform); | |||
| const fetcherOptions = SUPPORTER_PLATFORMS.map(platform => platform === 'mac' ? 'mac10.16' : platform); | |||
There was a problem hiding this comment.
I believe this is not really needed?
|
@p0x6 Thank you for the PR! Just to re-iterate: do I understand correctly that all our Chromium, Firefox and WebKit actually work for you on Big Sur? |
You are correct. I am running playwright tests on Big Sur beta (mac10.16) with my changes. Using the current binaries. I am not sure if it will be the case when Big Sur is officially released as mac11.0, but as of now the beta works. |
|
@p0x6 we discussed this offline with the team. It was decided that we can't add BigSur without bots support, and currently there are no BigSur machines in either of the CI providers we use. So I'll have to refrain from merging this; we'll probably get back to this in fall once BigSur is officially released. |
|
Is the reason just support? There are a lot of devs on the beta. Couldn't we merge this with a warning on the console that Big Sur is not officially supported? |
|
Hey Playwright team, |
macOS 11.0 Big Sur was released as a preview on GitHub Actions: actions/runner-images#1781 (comment) Closes #2789 Relates #2793
Adding mac10.16 to be supported. This is the macOS Big Sur beta version.
Begins to fix: #2789