Skip to content

fix: disable memory cache when intercepting in webkit #28458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 1 commit into from
Dec 1, 2023
Merged

fix: disable memory cache when intercepting in webkit #28458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/playwright-core/src/server/webkit/wkPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ export class WKPage implements PageDelegate {
];
if (this._page.needsRequestInterception()) {
promises.push(session.send('Network.setInterceptionEnabled', { enabled: true }));
promises.push(session.send('Network.setResourceCachingDisabled', { disabled: true }));
promises.push(session.send('Network.addInterception', { url: '.*', stage: 'request', isRegex: true }));
}
if (this._page._browserContext.isSettingStorageState()) {
Expand Down Expand Up @@ -723,6 +724,7 @@ export class WKPage implements PageDelegate {
const enabled = this._page.needsRequestInterception();
await Promise.all([
this._updateState('Network.setInterceptionEnabled', { enabled }),
this._updateState('Network.setResourceCachingDisabled', { disabled: enabled }),
this._updateState('Network.addInterception', { url: '.*', stage: 'request', isRegex: true }),
]);
}
Expand Down
18 changes: 18 additions & 0 deletions tests/page/interception.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,3 +172,21 @@ it('should not break remote worker importScripts', async ({ page, server, browse
await page.goto(server.PREFIX + '/worker/worker-http-import.html');
await page.waitForSelector("#status:has-text('finished')");
});

it('should disable memory cache when intercepting', async ({ page, server }) => {
let interceted = 0;
await page.route('**/page.html', route => {
++interceted;
void route.fulfill({
body: 'success'
});
});
await page.goto(server.PREFIX + '/page.html');
expect(await page.locator('body').textContent()).toContain('success');
await page.goto(server.EMPTY_PAGE);
await expect(page).toHaveURL(server.EMPTY_PAGE);
expect(interceted).toBe(1);
await page.goBack();
await expect(page).toHaveURL(server.PREFIX + '/page.html');
expect(interceted).toBe(2);
});