feat(trace): allow Trace Viewer to include credentials when fetching traces cross-origin #28502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…traces cross-origin Add the "'credentials': include" option on the trace fetch so the browser can include cookies when fetching from a different origin, assuming the origin returns the correct Access-Control-Allow-Origin and Access-Control-Allow-Credentials headers. Fixes microsoft#28501
Test results for "tests 1"3 flaky26279 passed, 615 skipped Merge workflow run. |
dgozman
approved these changes
Dec 14, 2023
|
Thank you! |
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Jan 17, 2024
…etching traces cross-origin (microsoft#28502)" This reverts commit 3f3f332.
dgozman
added a commit
that referenced
this pull request
Jan 17, 2024
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Jan 17, 2024
…etching traces cross-origin (microsoft#28502)" (microsoft#29024) This reverts commit 3f3f332. References microsoft#29019.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
'credentials': includeoption on the trace fetch so the browser can include cookies when fetching from a different origin, assuming the origin returns the correct Access-Control-Allow-Origin and Access-Control-Allow-Credentials headers.Fixes #28501