Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always enable ESM loader with the new API #29991

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Mar 18, 2024

It does not require a process restart anymore, so safe to enable.

Fixes #29747.

This comment has been minimized.

This comment has been minimized.

It does not require a process restart anymore, so safe to enable.
Copy link
Contributor

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium-page] › page/interception.spec.ts:104:3 › should intercept network activity from worker
⚠️ [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

26822 passed, 620 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit be1af15 into microsoft:main Mar 19, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Typescript tests raise TypeError when one of project or file is a module
2 participants