Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prepare to reuse test server from ui mode (6) #30008

Merged
merged 1 commit into from
Mar 20, 2024
Merged

chore: prepare to reuse test server from ui mode (6) #30008

merged 1 commit into from
Mar 20, 2024

Conversation

pavelfeldman
Copy link
Member

No description provided.

@pavelfeldman pavelfeldman force-pushed the ui_mode_6 branch 2 times, most recently from 5001d35 to d75c191 Compare March 19, 2024 21:39
@pavelfeldman pavelfeldman changed the title UI mode 6 chore: prepare to reuse test server from ui mode (6) Mar 19, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

8 flaky ⚠️ [chromium-page] › page/interception.spec.ts:104:3 › should intercept network activity from worker
⚠️ [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots
⚠️ [playwright-test] › ui-mode-trace.spec.ts:76:5 › should merge screenshot assertions
⚠️ [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [webkit-library] › library/screenshot.spec.ts:75:14 › page screenshot › should work with device scale factor
⚠️ [webkit-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline

26836 passed, 620 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman pavelfeldman merged commit 48ccc9c into microsoft:main Mar 20, 2024
29 of 30 checks passed
@dgozman dgozman mentioned this pull request Apr 9, 2024
Merged
mxschmitt added a commit that referenced this pull request Apr 10, 2024
@mxschmitt
fix(ui-mode): do not loose run information after writing into testDir (…
15b4231 
…#30312)

Partially reverts #30008
that started to reset all test results upon listing tests, including the
test that did just run and triggered re-listing.

#30300.
mxschmitt added a commit to mxschmitt/playwright that referenced this pull request Apr 10, 2024
@mxschmitt
cherry-pick(microsoft#30312): fix(ui-mode): do not loose run informat…
ea41bad 
…ion after writing into testDir

Partially reverts microsoft#30008
that started to reset all test results upon listing tests, including the
test that did just run and triggered re-listing.

microsoft#30300.
@mxschmitt mxschmitt mentioned this pull request Apr 10, 2024
Merged
mxschmitt added a commit that referenced this pull request Apr 11, 2024
@mxschmitt
cherry-pick(#30312): fix(ui-mode): do not loose run information after…
3ab466e 
… writing into testDir (#30328)

Partially reverts #30008
that started to reset all test results upon listing tests, including the
test that did just run and triggered re-listing.

#30300.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelfeldman @dgozman