Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): allow launching with spaces in path #30820

Merged
merged 1 commit into from
May 15, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented May 15, 2024

Fixes #30755

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the bugfix/electron-spaces branch from 7dfa031 to 04ddeed Compare May 15, 2024 10:39
@mxschmitt mxschmitt added the CQ1 label May 15, 2024

This comment has been minimized.

Copy link
Contributor

Test results for "tests 2"

4 fatal errors, not part of any test
8 failed
❌ [chromium-page] › page/page-network-request.spec.ts:320:3 › should return multipart/form-data
❌ [chromium-page] › page/page-network-request.spec.ts:320:3 › should return multipart/form-data
❌ [chromium-page] › page/page-network-request.spec.ts:320:3 › should return multipart/form-data
❌ [chromium-page] › page/page-network-request.spec.ts:320:3 › should return multipart/form-data
❌ [chromium-page] › page/page-network-request.spec.ts:320:3 › should return multipart/form-data
❌ [chromium-page] › page/page-network-request.spec.ts:320:3 › should return multipart/form-data
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url

32 flaky ⚠️ [chromium-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium-page] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1064:1 › should pick locator in iframe
⚠️ [chromium-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [chromium-page] › page/page-mouse.spec.ts:221:3 › should tween mouse movement
⚠️ [firefox-library] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox-page] › page/page-drag.spec.ts:25:5 › Drag and drop › should work @smoke
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:331:3 › should emulate media in cross-process iframe
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [firefox-library] › library/har.spec.ts:455:3 › should have -1 _transferSize when its a failed request
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:751:7 › cli codegen › should record slider
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:138:7 › cli codegen › should upload multiple files
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:200:7 › cli codegen › should download files
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox-page] › page/page-click.spec.ts:99:3 › should click the 1x1 div
⚠️ [firefox-page] › page/page-click.spec.ts:850:3 › should not hang when frame is detached
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
⚠️ [firefox-page] › page/page-click.spec.ts:850:3 › should not hang when frame is detached
⚠️ [chromium-page] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [chromium-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:157:3 › should upload large file with relative path
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:444:7 › cli codegen › should generate getByAltText
⚠️ [webkit-page] › page/page-drag.spec.ts:25:5 › Drag and drop › should work @smoke
⚠️ [webkit-page] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit-library] › library/tracing.spec.ts:412:14 › should produce screencast frames fit
⚠️ [webkit-library] › library/tracing.spec.ts:412:14 › should produce screencast frames crop
⚠️ [webkit-library] › library/tracing.spec.ts:412:14 › should produce screencast frames scale

169484 passed, 7550 skipped, 2646 did not run
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt force-pushed the bugfix/electron-spaces branch from 04ddeed to bdc077c Compare May 15, 2024 16:15
@mxschmitt mxschmitt merged commit 90765a2 into microsoft:main May 15, 2024
28 of 29 checks passed
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [installation tests] › playwright-electron-should-work.spec.ts:30:5 › electron should work with special characters in path

1 flaky ⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots

27345 passed, 662 skipped
✔️✔️✔️

Merge workflow run.

mxschmitt pushed a commit that referenced this pull request May 15, 2024
…th (#30830)

This PR cherry-picks the following commits:

- 90765a2

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression]: Playwright 1.44 cannot start Electron application with path contains spaces (Windows)
2 participants