Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-certificates): when server does tls renegotiation #32155

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Aug 14, 2024

Certain https servers like Microsoft IIS aka. TLS servers do the TLS renegotiation after the TLS handshake. This ends up in two 'secureConnect' events due to an upstream Node.js bug: nodejs/node#54362

Drive-by: Move other listeners like 'close' / 'end' to once() as well.

Relates #32004

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › playwright.artifacts.spec.ts:195:5 › should work with screenshot: only-on-failure & fullPage

1 flaky ⚠️ [firefox-page] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy

29801 passed, 765 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 4daf5c2 into microsoft:main Aug 14, 2024
29 of 30 checks passed
mxschmitt added a commit that referenced this pull request Aug 14, 2024
…enegotiation

Certain https servers like Microsoft IIS aka. TLS servers do the TLS
renegotiation after the TLS handshake. This ends up in two
`'secureConnect'` events due to an upstream Node.js bug:
nodejs/node#54362

Drive-by: Move other listeners like `'close'` / `'end'` to `once()` as
well.

Relates #32004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants