Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client-certificates): allow passing certificates from memory #32210

Conversation

mxschmitt
Copy link
Member

Motivation: We received multiple feedback from users who want to add certificates from in-memory.

Fixes #32200

docs/src/api/params.md Outdated Show resolved Hide resolved
@mxschmitt mxschmitt requested a review from dgozman August 18, 2024 08:02

This comment has been minimized.

docs/src/api/params.md Outdated Show resolved Hide resolved
@mxschmitt mxschmitt force-pushed the feature/client-certificates-allow-passing-content branch from f7132ed to 87e9c61 Compare August 19, 2024 07:13

This comment has been minimized.

This comment has been minimized.

@mxschmitt mxschmitt merged commit 010778f into microsoft:main Aug 19, 2024
28 of 29 checks passed
@mxschmitt mxschmitt changed the title feat(client-certificates): allow passing certificates in memory feat(client-certificates): allow passing certificates from memory Aug 19, 2024
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › runner.spec.ts:274:5 › should not stall when workers are available

4 flaky ⚠️ [firefox-library] › library/client-certificates.spec.ts:417:3 › browser › should pass with matching certificates on context APIRequestContext instance
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live
⚠️ [webkit-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation

30043 passed, 860 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Load client certificates from RAM
2 participants