chore(ui): add test for font preview #32225
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tests/library/trace-viewer.spec.ts
Outdated
| await expect(traceViewer.networkRequests).toHaveCount(1); | ||
| await traceViewer.networkRequests.getByText('font.woff2').click(); | ||
| await traceViewer.page.getByTestId('network-request-details').getByTitle('Body').click(); | ||
| await expect(traceViewer.page.locator('.network-request-details-tab')).toHaveScreenshot({ maxDiffPixelRatio: 0.1 }); |
There was a problem hiding this comment.
The chances are this screenshot will not work across various operating systems and configurations. You can try adding a label CQ1 to check that. I'd recommend checking that text "ABCDEF" is present in the preview instead.
There was a problem hiding this comment.
Today I learned about CQ1! Just for my understanding, do we run those fat tests on any label, or only on CQ1? looking at https://github.com/Skn0tt/playwright/blob/2feaecd34eeaecb81534d66d9317b6bbd8463319/.github/workflows/tests_secondary.yml#L12.
There was a problem hiding this comment.
updated the test in a86831d
There was a problem hiding this comment.
The trigger is for any label but we never add labels for PRs, so we usually use just CQ1.
Test results for "tests others"1 failed 18010 passed, 488 skipped Merge workflow run. |
Test results for "tests 1"3 failed 1 flaky30100 passed, 870 skipped Merge workflow run. |
Test results for "tests 2"4 fatal errors, not part of any test 98 flaky230837 passed, 9844 skipped, 5 did not run Merge workflow run. |
Adds a test for the font preview feature.