Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): move TeleSuiteUpdater into testIsomorphic #32273

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Aug 22, 2024

Preparation for #32076.

@Skn0tt Skn0tt requested a review from dgozman August 22, 2024 14:52
@Skn0tt Skn0tt self-assigned this Aug 22, 2024
@Skn0tt Skn0tt changed the title refactor(ui): move TeleSuiteUpdater into testIsomorphic chore(ui): move TeleSuiteUpdater into testIsomorphic Aug 22, 2024
import type * as reporterTypes from '../../types/testReporter';

export type TeleSuiteUpdaterProgress = {
total: number;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2 spaces instead of 4. I wonder why linter does not complain...

This comment has been minimized.

@Skn0tt Skn0tt merged commit 850436c into microsoft:main Aug 22, 2024
19 of 20 checks passed
Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [webkit-library] › library/modernizr.spec.ts:33:3 › safari-14-1
❌ [webkit-library] › library/modernizr.spec.ts:83:3 › mobile-safari-14-1

2 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:248:1 › should have network requests
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all

30094 passed, 870 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants