Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addInitScript): require non-undefined arg to trigger commonjs module #32282

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Aug 23, 2024

No description provided.

@dgozman dgozman force-pushed the fix-add-init-script-arg-undefined branch from ed8a5f3 to da2797d Compare August 23, 2024 08:46
Copy link
Contributor

Test results for "tests 1"

3 failed
❌ [playwright-test] › web-server.spec.ts:153:5 › should resolve cwd wrt config directory
❌ [webkit-library] › library/modernizr.spec.ts:33:3 › safari-14-1
❌ [webkit-library] › library/modernizr.spec.ts:83:3 › mobile-safari-14-1

1 flaky ⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation

30094 passed, 870 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit 3a75f23 into microsoft:main Aug 23, 2024
28 of 30 checks passed
yury-s added a commit to yury-s/playwright that referenced this pull request Aug 28, 2024
yury-s added a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants