Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locator handler): perform checkpoit during locator.waitFor #32683

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Sep 18, 2024

Fixes #32255.

Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [installation tests] › playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path
❌ [playwright-test] › babel.spec.ts:135:5 › should not transform external

4 flaky ⚠️ [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config
⚠️ [playwright-test] › ui-mode-test-attachments.spec.ts:102:5 › should linkify string attachments
⚠️ [webkit-page] › page/page-goto.spec.ts:301:3 › should fail when navigating to bad SSL
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all

35506 passed, 659 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit f9d9ad2 into microsoft:main Sep 18, 2024
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: check locator handlers while retrying during locator.waitFor
2 participants