Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move Location type from testReporter.d.ts to test.d.ts #32687

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Sep 18, 2024

Fixes #32680

Problem: Location type is a global in node_modules/typescript/lib/lib.dom.d.ts.

Previously we used it only in our reporters (testReporter.d.ts) now we also use it inside test.d.ts. We don't want to import testReporter from test.d.ts, hence moving the type into test.d.ts.

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › babel.spec.ts:135:5 › should not transform external

5 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:415:7 › cli codegen › should update selected element after pressing Tab
⚠️ [firefox-library] › library/page-clock.spec.ts:282:3 › stubTimers › replaces global performance.timeOrigin
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:22:5 › should update trace live
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path
⚠️ [webkit-library] › library/download.spec.ts:712:3 › should download links with data url

35495 passed, 659 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to update sidebars at playwright.dev as well.

@mxschmitt mxschmitt merged commit 523ec83 into microsoft:main Sep 18, 2024
29 of 30 checks passed
@osohyun0224
Copy link
Contributor

@mxschmitt @dgozman
Quickly take follow-up action on bugs arising from PRs I opened Thank you for proceeding. I am grateful to the playwright team for always developing great open source products 🙂🙂

@jan-molak
Copy link
Contributor

Thanks for the fix, @mxschmitt and @dgozman - I'll check tomorrow when the next nightly build is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Playwright Test should export the Location interface
4 participants