test: fix client-certificate tests #32691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
fix-cc-tests2
branch
2 times, most recently
from
8d4ff03
to
46dbe68
Compare
This comment has been minimized.
This comment has been minimized.
mxschmitt
commented
Sep 18, 2024
| @@ -365,7 +365,8 @@ test.describe('browser', () => { | |||
| }); | |||
| expect(proxyServer.connectHosts).toEqual([]); | |||
| await page.goto(serverURL); | |||
| expect([...new Set(proxyServer.connectHosts)]).toEqual([`127.0.0.1:${new URL(serverURL).port}`]); | |||
| const host = browserName === 'webkit' && process.platform === 'darwin' ? 'localhost' : '127.0.0.1'; | |||
There was a problem hiding this comment.
We rewrite it from local.playwright to localhost for WebKit/macOS.
dgozman
approved these changes
Sep 19, 2024
mxschmitt
force-pushed
the
fix-cc-tests2
branch
from
46dbe68
to
129a45d
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"35512 passed, 659 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.