Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bidi): run firefox tests against nightly build #32737

Merged
merged 1 commit into from
Sep 20, 2024
Merged

chore(bidi): run firefox tests against nightly build #32737

merged 1 commit into from
Sep 20, 2024

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Sep 20, 2024

No description provided.

mxschmitt
mxschmitt approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Whats your take in line 9 adding: **bidi**?
  • Maybe delete the beta expectations?

@yury-s yury-s merged commit bef1e99 into microsoft:main Sep 20, 2024
29 of 31 checks passed
@yury-s yury-s deleted the bidi-run-nightly branch September 20, 2024 19:57
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:256:1 › should have network requests
⚠️ [webkit-library] › library/download.spec.ts:698:3 › should convert navigation to a resource with unsupported mime type into download

35687 passed, 672 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yury-s @mxschmitt