feat(trace): highlight strict mode violation elements in the snapshot #32893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing a case where the test failed with strict mode violation, but all the matched elements are not highlighted in the trace.
For example, all the buttons will be highlighted when the following line fails due to strict mode violation:
To achieve this, we mark elements during
querySelector
phase instead of insideonBeforeInputAction
. This allows us to only mark from inside theInjectedScript
and remove the other way of marking from inside theSnapshotter
.