fix(global setup): simplify ordering #33444
Conversation
| expect(result.output).toContain('Error: kaboom'); | ||
| }); | ||
|
|
||
| test('globalTeardown runs even if callback failed', async ({ runInlineTest }) => { |
There was a problem hiding this comment.
I think this is already covered by globalSetup1 from the previous test, isn't it?
There was a problem hiding this comment.
it is, yes. and it's also covered from the other test I had to touch. but since this is the main breaking behaviour change, and I wanted to have an explicit test to cover this.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@dgozman I had to change two more tests here in |
Seems fine to me, we have explicitly agreed on this behavior. |
Test results for "tests 1"3 failed 1 flaky36757 passed, 678 skipped Merge workflow run. |
As.discussed yesterday, this PR follows up on #32955 with some ordering simplification. The new ordering is:
globalSetupentries, in direct orderglobalSetup, in reverse orderglobalTeardownentries, in direct orderBefore we added support for multiple global setups, a failing callback meant that we wouldn't execute the teardown. This is broken by this change.