fix(expect): adjust normalization for regex values in toHaveText matcher #33533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengooseDev
changed the title
This comment has been minimized.
This comment has been minimized.
pengooseDev
force-pushed
the
fix-toHaveText-regex
branch
from
30c12e9
to
d3484a5
Compare
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Nov 11, 2024
pengooseDev
force-pushed
the
fix-toHaveText-regex
branch
from
d3484a5
to
4141467
Compare
yury-s
approved these changes
Nov 12, 2024
Test results for "tests 1"1 failed 3 flaky36902 passed, 690 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29382
toEqualcall when theexpectedtype intoHaveTextis(string | RegExp)[]. Since we cannot modify the external dependencythis.utils.printDiffOrStringify, normalization is performed before invoking it.toMatchTextmethod, which handles cases where the type isstring | RegExp, to ensure that regex values are processed correctly. Regression tests confirmed that no issues are present.