chore: migrate @web to @playwright/web
#34013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
migrate-web-to-package
branch
from
7615d87 to
84838d6
Compare
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
migrate-web-to-package
branch
from
84838d6 to
fc1e986
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"4 flaky37292 passed, 650 skipped Merge workflow run. |
mxschmitt
changed the title
@web to @playwright/web
This was referenced Dec 14, 2024
dgozman
reviewed
Dec 16, 2024
| @@ -1,6 +1,6 @@ | |||
| [*] | |||
| @playwright/experimental-ct-react | |||
| @web/** | |||
| @playwright/web/** | |||
There was a problem hiding this comment.
Suggested change
| @playwright/web/** | |
| @playwright/web |
| @@ -19,7 +19,7 @@ import './chip.css'; | |||
| import './colors.css'; | |||
| import './common.css'; | |||
| import * as icons from './icons'; | |||
| import { clsx } from '@web/uiUtils'; | |||
| import { clsx } from '@playwright/web/src/uiUtils'; | |||
There was a problem hiding this comment.
In playwright we import stuff from playwright-core differently:
import { formatCallLog } from 'playwright-core/lib/utils';
Similarly, @playwright/experimental-ct-core imports from @playwright/test differently:
import { Watcher } from 'playwright/lib/fsWatcher';
Why is this one different?
| if (packages.has(package)) | ||
| importPath = packages.get(package) + tokens.slice(1).join('/'); | ||
| if (packages.has(`@${tokens[0]}/${tokens[1]}`)) { | ||
| // Namespaced package. |
There was a problem hiding this comment.
What does "namespaced" mean here?
| importPath = packages.get(package) + tokens.slice(1).join('/'); | ||
| if (packages.has(`@${tokens[0]}/${tokens[1]}`)) { | ||
| // Namespaced package. | ||
| importPath = packages.get(`@${tokens[0]}/${tokens[1]}`) + tokens.slice(2).join('/'); |
There was a problem hiding this comment.
Why is this different from other packages, e.g. playwright-core? I'd leave importPath undefined and go the line 162 old code instead.
| @@ -192,8 +202,9 @@ async function innerCheckDeps(root) { | |||
| } | |||
| if (line === '***') | |||
| group.push('***'); | |||
| else if (line.startsWith('@')) | |||
| group.push(line.replace(/@([\w-]+)\/(.*)/, (_, arg1, arg2) => packages.get(arg1) + arg2)); | |||
| else if (line.startsWith('@')) { | |||
There was a problem hiding this comment.
- I don't really get this change.
- styling is off 😄
| @@ -14,7 +14,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| import { ansi2html } from '@web/ansi2html'; | |||
| import { ansi2html } from '../ansi2html'; | |||
There was a problem hiding this comment.
Great fixes in packages/web!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first iteration on an attempt to get rid of local tsconfig package aliases in order to simplify the imports. It uses the more common package name imports what NPM workspaces offer out of the box. This also helps us to adopt tsconfig package references (not decided yet) and makes the boundaries clearer between the packages.
The next iterations would be to do something similar for:
@html-reporter-> rename to@playwright/html-reporter@protocol-> rename to@playwright/protocol@recorder-> rename to@playwright/recorder@trace-> rename to@playwright/trace