Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download browsers as TAR #34033

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: download browsers as TAR #34033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a9b40bd
add second branch
Skn0tt Dec 16, 2024
0b139f1
move chromium, chromium-tot, and webkit to brotli
Skn0tt Dec 16, 2024
98d6138
fix import
Skn0tt Dec 16, 2024
657e435
feat: download browsers as .tar.br
Skn0tt Dec 16, 2024
c5ab0c5
respect revisionOverrides
Skn0tt Dec 18, 2024
3b72c3b
update thirdparty
Skn0tt Dec 18, 2024
411cf29
update log line matcher
Skn0tt Dec 18, 2024
d880a22
update expected error codes
Skn0tt Dec 18, 2024
f39ae50
ffmpeg also has brotli builds now
Skn0tt Dec 18, 2024
f071337
remove conflicting tar-fs types
Skn0tt Dec 18, 2024
45b84b7
add workaround for manually-created ffmpeg archive
Skn0tt Dec 18, 2024
a497b6b
remove console statement
Skn0tt Dec 18, 2024
b048d2a
Merge branch 'main' into tar-download-3rd-party-lib
Skn0tt Dec 18, 2024
affff4d
Merge branch 'main' into tar-download-3rd-party-lib
Skn0tt Dec 19, 2024
879afb1
adapt to new ffmpeg roll
Skn0tt Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,586 changes: 1,585 additions & 1 deletion packages/playwright-core/ThirdPartyNotices.txt
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions packages/playwright-core/browsers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@
"revision": "1011",
"installByDefault": true,
"revisionOverrides": {
"mac12": "1010",
"mac12-arm64": "1010"
"mac12": "1011",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the motivation for changing this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1010 doesn't have .tar.br, and 1010 is identical to 1011 in functionality

"mac12-arm64": "1011"
}
},
{
Expand Down
209 changes: 209 additions & 0 deletions packages/playwright-core/bundles/zip/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/playwright-core/bundles/zip/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
},
"dependencies": {
"extract-zip": "2.0.1",
"tar-fs": "^3.0.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the library is popular, but its deps list seem to be excessive for what it does a little. Did we consider alternatives?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, "tar" is even more...

Copy link
Member Author

@Skn0tt Skn0tt Dec 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we considered tar-fs, tar and writing our own. Writing our own turned out more complex than imagined, because webkit has very long path names and the format becomes tricky when that's involved. Of the three, tar-fs seemed the most focused.

"yauzl": "2.10.0",
"yazl": "2.5.1"
},
Expand Down
2 changes: 2 additions & 0 deletions packages/playwright-core/bundles/zip/src/zipBundleImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ export * as yazl from 'yazl';
export * as yauzl from 'yauzl';
import extractZip from 'extract-zip';
export const extract = extractZip;
// @ts-expect-error @types/tar-fs is broken and we're fine without it
export * as tarFs from 'tar-fs';
Loading
Loading