chore(lint): Experimenting with more strict linting rules - If braces and no-unnecessary-condition #34054
Conversation
| }); | ||
| this._channel.on('pageError', ({ error, page }) => { | ||
| const pageObject = Page.from(page); | ||
| const parsedError = parseError(error); | ||
| this.emit(Events.BrowserContext.WebError, new WebError(pageObject, parsedError)); | ||
| if (pageObject) |
There was a problem hiding this comment.
This seems to always be non-nullish. Should this check be re-added anyway?
| } | ||
| if (!browser.contexts()) |
There was a problem hiding this comment.
I don't see how this would ever be falsy.
| } | ||
| if (!browser.contexts()) |
There was a problem hiding this comment.
I don't see how this would ever be falsy again.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"15 fatal errors, not part of any test |
|
I still see a bunch of curly around one-liners, is that from before or after our discussion? Also bots seem to be unhappy. |
As we were discussing internally, explore applying rules to make
ifs display the same whether they're single or multi-line (always with braces.Additionally adds the
@typescript-eslint/no-unnecessary-conditionrule to use TypeScript to evaluate whether or not certain comparisons are necessary. Anywhere flagged by this rule indicates either a logic or types error, which I believe we should all be committed on fixing.This PR is cleanly separated into commits for each set of major changes:
ifbraces changes: b771466