Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable snapshots for most remaining public commands #34072

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Dec 18, 2024

Enable capturing snapshots on commands that have any visual component or interaction with the DOM. This is an interim solution to #33934. In the future we will display stale snapshots on trace entries that do not contain a snapshot.

Copy link
Contributor

Test results for "tests 1"

6 failed
❌ [chromium-library] › library/inspector/pause.spec.ts:174:5 › pause › should highlight pointer, only in main frame @chromium-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:174:5 › pause › should highlight pointer, only in main frame @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/inspector/pause.spec.ts:174:5 › pause › should highlight pointer, only in main frame @chromium-ubuntu-22.04-node22
❌ [firefox-library] › library/inspector/pause.spec.ts:174:5 › pause › should highlight pointer, only in main frame @firefox-ubuntu-22.04-node18
❌ [chromium-library] › library/inspector/pause.spec.ts:174:5 › pause › should highlight pointer, only in main frame @ubuntu-20.04-chromium-tip-of-tree
❌ [webkit-library] › library/inspector/pause.spec.ts:174:5 › pause › should highlight pointer, only in main frame @webkit-ubuntu-22.04-node18

11 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @ubuntu-20.04-chromium-tip-of-tree
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:683:5 › run-server › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:238:7 › cli codegen › should not target selector preview by text regexp @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:149:1 › should open simple trace viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1431:1 › should not record route actions @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-update.spec.ts:83:5 › should pick new / deleted tests @windows-latest-node18-1

37326 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but make sure you fix those tests before landing/

@pavelfeldman
Copy link
Member

As this closes the issue for count(), having a test that checks that count() has gotten a snapshot would be nice as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants