chore: builtins #35197
Merged
chore: builtins #35197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Mar 17, 2025
This comment has been minimized.
This comment has been minimized.
This introduces a "script to evaluate on new document" that saves certain builtin objects like `Map` into an unguessable global property. Later on, every injected script will try to use the saved builtins. The idea is to workaround pages that mess around with certain objects like `Set` or `Map` and break Playwright's injected code. All injected source files are now subject to an eslint rule that forces the use of `Builtins.Map` instead of `Map` or similar. Many utility functions got a `builtins` argument to be able to construct non-overridden builtins. Pros: - Playwright should work on a broader set of web pages. - Over time, we can cover more builtin classes/functions. Cons: - Passing around `builtins` object in the codebase. - Extra eslint rule. - A tiny but mandatory script evaluated on each page load.
Test results for "tests others"4 flaky21793 passed, 512 skipped Merge workflow run. |
Test results for "tests 1"2 flaky38839 passed, 809 skipped Merge workflow run. |
Test results for "tests 2"9 failed 113 flaky236883 passed, 9312 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a "script to evaluate on new document" that saves certain builtin objects like
Mapas an unlisted global property. Later on, every injected script will try to use the saved builtins.The idea is to workaround pages that mess around with certain objects like
SetorMapand break Playwright's injected code.All injected source files are now subject to an eslint rule that forces the use of
Builtins.Mapinstead ofMapor similar. Many utility functions got abuiltinsargument to be able to construct non-overridden builtins.Pros:
Cons:
builtinsobject in the codebase.References #34443. References #34628.