chore: use a singleton "builtins" instead of passing it around#35493
Merged
dgozman merged 3 commits intomicrosoft:mainfrom Apr 10, 2025
Merged
chore: use a singleton "builtins" instead of passing it around#35493dgozman merged 3 commits intomicrosoft:mainfrom
dgozman merged 3 commits intomicrosoft:mainfrom
Conversation
yury-s
reviewed
Apr 4, 2025
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
The PR looks good but it seems like we lack an agreement on babel vs explicit object approach.
dgozman
force-pushed
the
chore-builtins-simpler
branch
from
c043190 to
88cf24a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Apr 8, 2025
dgozman
force-pushed
the
chore-builtins-simpler
branch
from
88cf24a to
f78f319
Compare
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
chore-builtins-simpler
branch
from
f78f319 to
60c31f8
Compare
dgozman
changed the title
Contributor
Test results for "tests 1"1 failed 7 flaky39108 passed, 807 skipped Merge workflow run. |
yury-s
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also enable builtins linter for
utils/isomorphic.