Skip to content

chore: page.close -> Close page in steps #36834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025
Merged

chore: page.close -> Close page in steps #36834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22b60c3
chore: page.close -> `Close page` in steps
mxschmitt Jul 29, 2025
bd62f66
adjust tests
mxschmitt Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/playwright-core/src/utils/isomorphic/protocolMetainfo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export const methodMetainfo = new Map<string, { internal?: boolean, title?: stri
['BrowserContext.clockSetFixedTime', { title: 'Set fixed time "{timeNumber}{timeString}"', }],
['BrowserContext.clockSetSystemTime', { title: 'Set system time "{timeNumber}{timeString}"', }],
['Page.addInitScript', { }],
['Page.close', { title: 'Close', }],
['Page.close', { title: 'Close page', }],
['Page.emulateMedia', { title: 'Emulate media', snapshot: true, }],
['Page.exposeBinding', { title: 'Expose binding', }],
['Page.goBack', { title: 'Go back', slowMo: true, snapshot: true, }],
Expand Down
2 changes: 1 addition & 1 deletion packages/protocol/src/protocol.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1554,7 +1554,7 @@ Page:
source: string

close:
title: Close
title: Close page
parameters:
runBeforeUnload: boolean?
reason: string?
Expand Down
4 changes: 2 additions & 2 deletions tests/library/tracing.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ test('should collect trace with resources, but no js', async ({ context, page, s
'Navigate to "/input/fileupload.html"',
'Set input files',
'Wait for timeout',
'Close',
'Close page',
]);

expect(events.some(e => e.type === 'frame-snapshot')).toBeTruthy();
Expand Down Expand Up @@ -200,7 +200,7 @@ test('should collect two traces', async ({ context, page, server }, testInfo) =>
expect(events[0].type).toBe('context-options');
expect(actions).toEqual([
'Double click',
'Close',
'Close page',
]);
}
});
Expand Down
Loading