fix(trace): don't replace unknown braces in action title #36920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Aug 5, 2025
| title.push(chunk); | ||
|
|
||
| const param = formatProtocolParam(action.params, quotedText); | ||
| if (!param) { |
Contributor
There was a problem hiding this comment.
Let's make formatProtocolParam return undefined for failures, so we can differentiate between an empty string and a missing param.
We should also update renderTitleForCall.
Member
Author
There was a problem hiding this comment.
Done. I also had to change the title in protocol.yml to remove our "{a}{b}" syntax of optionality, since it's clashing with this change.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Aug 5, 2025
packages/protocol/src/protocol.yml
Outdated
|
|
||
| clockFastForward: | ||
| title: Fast forward clock "{ticksNumber}{ticksString}" | ||
| title: Fast forward clock "{ticks}" |
Contributor
There was a problem hiding this comment.
How about {ticksNumber|ticksString}?
| if (param === undefined) { | ||
| elements.push(fullMatch); | ||
| title.push(fullMatch); | ||
| currentIndex = match.index + fullMatch.length; |
Contributor
There was a problem hiding this comment.
nit: I'd prefer this line to not be repeated, perhaps if () {} else if () {} else {} would be better?
dgozman
approved these changes
Aug 5, 2025
| return params[name]; | ||
| return urlObject.pathname + urlObject.search; | ||
| } catch (error) { | ||
| return params[name]; |
Contributor
There was a problem hiding this comment.
Suggested change
| return params[name]; | |
| if (params[name] !== undefined) | |
| return params[name]; |
| if (name === 'timeNumber') { | ||
| // eslint-disable-next-line no-restricted-globals | ||
| return new Date(params[name]).toString(); | ||
| return new Date(params[name]).toString(); |
Contributor
There was a problem hiding this comment.
Suggested change
| return new Date(params[name]).toString(); | |
| if (params[name] !== undefined) | |
| return new Date(params[name]).toString(); |
Contributor
Test results for "tests 1"1 failed 7 flaky46578 passed, 806 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36483