Skip to content

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Aug 18, 2025

Depends on #36727 to be merged first. Closes #36727.

@Skn0tt Skn0tt self-assigned this Aug 18, 2025
@github-actions

This comment has been minimized.

Copy link
Contributor

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new WebKit roll is merged - please rebase / fix lints.

@Skn0tt Skn0tt marked this pull request as ready for review August 18, 2025 11:30
@github-actions
Copy link
Contributor

Test results for "tests 1"

9 flaky ⚠️ [chromium-library] › library/page-clock.frozen.spec.ts:19 › clock should be frozen `@chromium-ubuntu-22.04-node18`
⚠️ [chromium-library] › library/page-close.spec.ts:22 › should close page with active dialog `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/page-clock.frozen.spec.ts:19 › clock should be frozen `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/page-clock.frozen.spec.ts:19 › clock should be frozen `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-library] › library/inspector/recorder-api.spec.ts:49 › should click `@firefox-ubuntu-22.04-node18`
⚠️ [chromium-library] › library/inspector/console-api.spec.ts:38 › should support playwright.$, playwright.$$ `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:24 › cli codegen › should contain open page `@webkit-ubuntu-22.04-node18`

46616 passed, 802 skipped


Merge workflow run.

@Skn0tt Skn0tt merged commit c7bf035 into microsoft:main Aug 18, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][WebKit][WPE]: Playwright Does Not Close <dialog>s When Escape Is Pressed on a [contenteditable] Element (Linux/WebKit)

2 participants