-
Notifications
You must be signed in to change notification settings - Fork 5.1k
feat(mcp): console error and faster wait #37618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| const requestListener = (request: playwright.Request) => { | ||
| requests.add(request); | ||
| void request.response().then(() => responseListener(request)).catch(() => {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just add requestFinishedListener for both requestfinished/requestfailed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those would not arrive with response, that's what I am fixing...
tests/mcp/console.spec.ts
Outdated
| }); | ||
| }); | ||
|
|
||
| test.only('browser_console_messages errors only', async ({ client, server }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stray .only
b6ca2a3 to
45850e6
Compare
45850e6 to
e3c7ad7
Compare
> [!NOTE] > Mend has cancelled [the proposed renaming](https://redirect.github.com/renovatebot/renovate/discussions/37842) of the Renovate GitHub app being renamed to `mend[bot]`. > > This notice will be removed on 2025-10-07. <hr> This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [@playwright/mcp](https://playwright.dev) ([source](https://redirect.github.com/microsoft/playwright-mcp)) | [`0.0.40` -> `0.0.41`](https://renovatebot.com/diffs/npm/@playwright%2fmcp/0.0.40/0.0.41) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>microsoft/playwright-mcp (@​playwright/mcp)</summary> ### [`v0.0.41`](https://redirect.github.com/microsoft/playwright-mcp/releases/tag/v0.0.41) [Compare Source](https://redirect.github.com/microsoft/playwright-mcp/compare/v0.0.40...v0.0.41) - [microsoft/playwright@`86a00d0`](https://redirect.github.com/microsoft/playwright/commit/86a00d091808b9637e3b9ffd91c217ec3fec700d) chore(mcp): handle cross-fs video moves ([microsoft/playwright#37663](https://redirect.github.com/microsoft/playwright/pull/37663)) - [microsoft/playwright@`52b2da8`](https://redirect.github.com/microsoft/playwright/commit/52b2da831b47ba55b16cf5e62168c46361f4d885) chore(mcp): support --allowed-hosts=\* ([microsoft/playwright#37657](https://redirect.github.com/microsoft/playwright/pull/37657)) - [microsoft/playwright@`9f371ad`](https://redirect.github.com/microsoft/playwright/commit/9f371ad5e386f2f0afdca479400257b1ff5ea80f) feat(mcp): console error and faster wait ([microsoft/playwright#37618](https://redirect.github.com/microsoft/playwright/pull/37618)) - [microsoft/playwright@`2d33cdd`](https://redirect.github.com/microsoft/playwright/commit/2d33cddd44098ff9c479355152569e360497cf41) chore: do not rename video files outside --save-videos ([microsoft/playwright#37616](https://redirect.github.com/microsoft/playwright/pull/37616)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/izumin5210/dotfiles). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzEuOSIsInVwZGF0ZWRJblZlciI6IjQxLjEzMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
No description provided.