[DO NOT COMMIT] Mcp video dir test

.github/workflows/tests_mcp.yml

@@ -34,7 +34,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, macos-15, windows-latest]
+        os: [macos-15]
     runs-on: ${{ matrix.os }}
     permissions:
       id-token: write   # This is required for OIDC login (azure/login) to succeed
@@ -44,7 +44,7 @@ jobs:
     - uses: ./.github/actions/run-test
       with:
         node-version: "20"
-        command: npm run test-mcp
+        command: DEBUG=pw:browser npm run ctest-mcp -- --reporter=list
         bot-name: "mcp-${{ matrix.os }}"
         flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
         flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}

packages/playwright-core/src/server/browserContext.ts

@@ -533,6 +533,7 @@
       // Cleanup.
       const promises: Promise<void>[] = [];
       for (const { context, artifact } of this._browser._idToVideo.values()) {
+        console.error('Waiting for video to finish before closing context', context === this, artifact.localPath());
         // Wait for the videos to finish.
         if (context === this)
           promises.push(artifact.finishedPromise());

packages/playwright-core/src/server/videoRecorder.ts

@@ -112,6 +112,7 @@
   }
 
   writeFrame(frame: Buffer, timestamp: number) {
+    console.error('Writing frame at timestamp', timestamp);
     this._launchPromise.then(error => {
       if (error)
         return;
@@ -121,6 +122,7 @@
 
   private _writeFrame(frame: Buffer, timestamp: number) {
     assert(this._process);
+    console.error('VideoRecorder: _writeFrame', this._isStopped, { timestamp });
     if (this._isStopped)
       return;
 
@@ -155,6 +157,7 @@
   async stop() {
     // Only report the error on stop. This allows to make the constructor synchronous.
     const error = await this._launchPromise;
+    console.error('Stopping video recorder, error:', error);
     if (error)
       throw error;
     if (this._isStopped || !this._lastFrame)
@@ -165,9 +168,12 @@
     this._writeFrame(Buffer.from([]), this._lastFrame.timestamp + addTime);
     this._isStopped = true;
     try {
+      console.error('will wait _lastWritePromise');
       await this._lastWritePromise;
       await this._gracefullyClose!();
+      console.error('did stop video recorder');
     } catch (e) {
+      console.error('Error while stopping ffmpeg', e);
       debugLogger.log('error', `ffmpeg failed to stop: ${String(e)}`);
     }
   }