Skip to content

chore: delete request._headersMap #38723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 1 commit into from
Jan 9, 2026
Merged

chore: delete request._headersMap #38723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions packages/playwright-core/src/server/network.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ export class Request extends SdkObject {
private _method: string;
private _postData: Buffer | null;
readonly _headers: HeadersArray;
private _headersMap = new Map<string, string>();
readonly _frame: frames.Frame | null = null;
readonly _serviceWorker: pages.Worker | null = null;
readonly _context: contexts.BrowserContext;
Expand Down Expand Up @@ -155,7 +154,6 @@ export class Request extends SdkObject {
this._method = method;
this._postData = postData;
this._headers = headers;
this._updateHeadersMap();
this._isFavicon = url.endsWith('/favicon.ico') || !!redirectedFrom?._isFavicon;
}

Expand All @@ -166,15 +164,9 @@ export class Request extends SdkObject {

_applyOverrides(overrides: types.NormalizedContinueOverrides) {
this._overrides = { ...this._overrides, ...overrides };
this._updateHeadersMap();
return this._overrides;
}

private _updateHeadersMap() {
for (const { name, value } of this.headers())
this._headersMap.set(name.toLowerCase(), value);
}

overrides() {
return this._overrides;
}
Expand All @@ -200,7 +192,8 @@ export class Request extends SdkObject {
}

headerValue(name: string): string | undefined {
return this._headersMap.get(name);
const lowerCaseName = name.toLowerCase();
return this.headers().find(h => h.name.toLowerCase() === lowerCaseName)?.value;
}

// "null" means no raw headers available - we'll use provisional headers as raw headers.
Expand Down
Loading