Skip to content

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 9, 2026

Resolves some audits/alerts.

  • @modelcontextprotocol/sdk to 1.25.2;
  • zod-to-json-schema to 3.25.1;
  • qs to 6.14.1.

Unfortunately, re-exporting zodToJsonSchema type from the bundle now results in error TS2589: Type instantiation is excessively deep and possibly infinite. errors in some places. I removed the exact type, since the result is always immediately type-casted everywhere.

Also fix some type issues found after version bumps.

@dgozman dgozman requested a review from yury-s January 9, 2026 12:34
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@yury-s
Copy link
Member

yury-s commented Jan 9, 2026

For the context, this was reported upstream. Among other things the compilation became a few times slower and tsc was OOMing. Let's make sure that it doesn't regress compilation time significantly.

Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm provided the compilation time is acceptable. I don't see much progress on the upstream issue unfortunately.

@dgozman
Copy link
Contributor Author

dgozman commented Jan 12, 2026

lgtm provided the compilation time is acceptable. I don't see much progress on the upstream issue unfortunately.

Here are measurements on my laptop:

# without this PR
npm run tsc  18.03s user 0.68s system 223% cpu 8.358 total
npm run tsc  18.29s user 0.68s system 228% cpu 8.290 total

# with this PR
npm run tsc  17.35s user 0.60s system 227% cpu 7.884 total
npm run tsc  17.32s user 0.56s system 232% cpu 7.686 total

It looks like as any cuts off some work 😄

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Resolves some audits/alerts.

- `@modelcontextprotocol/sdk` to `1.25.2`;
- `zod-to-json-schema` to `3.25.1`;
- `qs` to `6.14.1`.
@github-actions
Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › playwright.spec.ts:877 › page.pause() should disable test timeout @macos-latest-node20
❌ [playwright-test] › ui-mode-test-setup.spec.ts:315 › web-mode: true › should run teardown with SIGINT @macos-latest-node20

3 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35 › should update locator highlight `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:796 › should update state on subsequent run `@macos-latest-node20`

34556 passed, 691 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "MCP"

3 failed
❌ [chromium] › mcp/sse.spec.ts:233 › sse transport shared context @mcp-macos-15
❌ [firefox] › mcp/test-debug.spec.ts:48 › test_debug (pause/resume) @mcp-macos-15
❌ [firefox] › mcp/test-debug.spec.ts:167 › test_debug (pause/snapshot/resume) @mcp-macos-15

2827 passed, 121 skipped


Merge workflow run.

@dgozman dgozman merged commit bba6d04 into microsoft:main Jan 16, 2026
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants