Skip to content

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 12, 2026

  • For resource overrides with a ref, meaning they have not changed the value, actually follow the ref.
  • Always report CSSOM-touched stylesheets in the overrides, to avoid rendering non-edited content when there were no recent changes in the stylesheet.
  • Honor the value of styleSheet.disabled.
  • Invalidate upon styleSheet.disabled assignment.

- For resource overrides with a `ref`, meaning they have not
  changed the value, actually follow the ref.
- Always report CSSOM-touched stylesheets in the overrides,
  to avoid rendering non-edited content when there were no
  recent changes in the stylesheet.
- Honor the value of `styleSheet.disabled`.
- Invalidate upon `styleSheet.disabled` assignment.
@dgozman dgozman requested a review from Skn0tt January 12, 2026 14:58
@github-actions
Copy link
Contributor

Test results for "MCP"

1 failed
❌ [chrome] › mcp/video.spec.ts:63 › should work with recordVideo (persistent) @mcp-macos-15

2821 passed, 116 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

7 failed
❌ [default] › debug-tests.spec.ts:516 › should not pause at the end of a setup test @vscode-extension
❌ [default-reuse] › debug-tests.spec.ts:516 › should not pause at the end of a setup test @vscode-extension
❌ [default-trace] › debug-tests.spec.ts:380 › should run global setup before debugging @vscode-extension
❌ [default-trace] › debug-tests.spec.ts:516 › should not pause at the end of a setup test @vscode-extension
❌ [playwright-test] › playwright.spec.ts:877 › page.pause() should disable test timeout @macos-latest-node20
❌ [playwright-test] › reporter-html.spec.ts:3311 › merged › shard chart @macos-latest-node20
❌ [playwright-test] › reporter-html.spec.ts:156 › created › should include image diff @macos-latest-node20

5 flaky ⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/headful.spec.ts:233 › should click in OOPIF `@chromium-ubuntu-22.04-node22`
⚠️ [webkit-page] › page/page-network-request.spec.ts:288 › should parse the data if content-type is application/x-www-form-urlencoded `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › runner.spec.ts:124 › should ignore subprocess creation error because of SIGINT `@macos-latest-node20`

34404 passed, 696 skipped


Merge workflow run.

@dgozman dgozman requested review from pavelfeldman and removed request for Skn0tt January 12, 2026 15:59
Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we touching this?

@dgozman
Copy link
Contributor Author

dgozman commented Jan 13, 2026

Why are we touching this?

I stumbled upon the bug when working on UI coverage and spent quite some time figuring things out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants